Chance Strickland
Chance Strickland
Thank you! Can you please run Prettier on all changed files to ensure formatting is consistent before I merge?
We should not be hard coding or exposing API keys. I was unaware that we are doing this currently, but that's worth changing while we're addressing it here.
Not entirely clear why this is needed. Can't you pass `aria-labelledby` and `aria-describedby` to the trigger directly? Doing so should override what we set internally.
> Unfortunately, that results in buggy behaviour where the screen reader announces the label three times In this example you are not overriding the `aria-describedby` prop. I guess what I'm...
We'll review when we can. +1 type comments are not helpful and just created noise for the maintainers, so I'd kindly request you to not add to that.
Should be addressed here: https://github.com/radix-ui/primitives/pull/3614
I think this is probably OK but I'm reconsidering how we handle our bubble fields which would negate the need here. Need to think through this a bit before I...
I think having a min-width of the trigger size is a good default for most cases. I think it might be better to have a separate custom property for the...
Practically speaking I'm not sure you would ever want a number value for a textarea, which I think is probably the reason we kept this as-is. I'm inclined in this...
It's not planned at the moment, and that's why it's closed :) For the moment we have limited bandwidth. There are a few new components we're planning and will discuss...