Charles-Francois Natali

Results 9 comments of Charles-Francois Natali

Hi @clacknya No it doesn't, however it could indeed be useful - would you be willing to maybe submit a patch? I don't use ntplib myself anymore so it might...

Thanks! Could you open a PR, it'd maek it easier to review.

Hi @dansebcar , Thanks for this interesting issue :). Indeed, NTPv2 has a 32-bit timestamp for seconds and the epoch is in 1900, so it suffers from rollover sometime in...

Hm, I'm not sure about adding a more specific exception than `ntplib.NTPException`, it feels really like a very specific case for something which should not really happen...

See https://github.com/cf-natali/ntplib/pull/22 which should raise a new exception: ``` $ faketime '2036-02-07 12:00:00' python3 -c 'import ntplib; print(ntplib.NTPClient().request("pool.ntp.org").offset)' Traceback (most recent call last): File "", line 1, in File "/home/cf/src/ntplib/ntplib.py",...

It's basically an invalid memory access when using a reference to the iterator elements. The smallest reproducer I could come up quickly with is: ``` $ cat test_yaml.cpp #include #include...

Hey, I'm sorry but I don't really have time to push this. It's actually complicated by the fact that gtest has two different ways to run subprocesses - `fork` and...

Just to be clear, this means that it's not possible to use blosc concurrently from multiple threads. I'm not talking about the threads managed by blosc itself, but by user...

Hm, reading the code I can't convince myself that event `b2nd_get_slice` is thread-safe: Under the hood it calls [b2nd_get_slice_cbuffer](https://github.com/Blosc/c-blosc2/blob/f6a9a0f54b0e2ace6804f55e5863f4ac3ebdd87b/blosc/b2nd.c#L985) with the source array, which in turn calls [get_set_slice](https://github.com/Blosc/c-blosc2/blob/f6a9a0f54b0e2ace6804f55e5863f4ac3ebdd87b/blosc/b2nd.c#L898), which in...