circuit

circuit copied to clipboard

StatSender interface signature has changed

1

Hi there, Tried configuring the `StatSender` in `statsdmetrics.CommandFactory{}` and realised the `statsdmetrics.StatSender` interface no longer matches the `StatSender` interface in `go-statsd-client`. https://github.com/cactus/go-statsd-client/blob/6348b56a993b50ba0d50dd9c3515c79dab38d639/statsd/client.go#L18-L28 Seems like they've introduced a new variadic parameter...

7ail

Retrieve request context data through metrics callback

8

## Problem Contexts can be used to manage information about requests. Some of these request's information may require logging. It will be useful to get these additional information via the...

aadedamola

Implement waiting max concurrency

8

Add a feature that uses https://github.com/golang/sync/blob/master/semaphore/semaphore.go to limit concurrency. In this implementation, rather than failing fast with an error, the function would wait according to the context if was at...

cep21

example config error

1

at `https://github.com/cep21/circuit/blob/v3.1.0/v3/example/main.go#L81` `circuit.Config{}` should be configured, like ``` circuit.Config{ General: circuit.GeneralConfig{ OpenToClosedFactory: hystrix.CloserFactory(hystrix.ConfigureCloser{}), ClosedToOpenFactory: hystrix.OpenerFactory(hystrix.ConfigureOpener{}), } ``` right?

daliny

An implementation of https://github.com/cep21/circuit/blob/master/v3/metrics/statsdmetrics/statsd.go in another repository with standardized tag names and platform independent. I think datadog style statsd tags will allow us to solve this in a generalized way

cep21

Allow adaptive limits

1

# Problem In the basic case, we want to time out or limit the rare bad request so we can maintain a good SLA. However, when problems happen (maybe the...

cep21

We should have tests to ensure statsd metric values don't change.

cep21

Hi! I'm thinking about what to modify for the v4 version of the library. Here is a feedback thread for all to contribute. Some ideas off the top of my...

cep21

This issue lists Renovate updates and detected dependencies. Read the [Dependency Dashboard](https://docs.renovatebot.com/key-concepts/dashboard/) docs to learn more.[View this repository on the Mend.io Web Portal](https://developer.mend.io/github/cep21/circuit). ## Open The following updates have all...

renovate[bot]

[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [golangci/golangci-lint-action](https://togithub.com/golangci/golangci-lint-action) | action | major | `v5` -> `v6` | ---...

renovate[bot]