apps icon indicating copy to clipboard operation
apps copied to clipboard

Feat: Support Corrections for Assets

Open mustermeiszer opened this issue 1 year ago • 2 comments

Previously, corrections were only supported for cash-assets as a means of handling bookkeeping errors.

A similar action should now be supported for the other assets two.

UI

  • Add a CTA besides Purchase/Finance, Sell/Repay called Correction
  • CTA is always visible

Content for Externally Priced Assets

CTA click → slice out like for the other CTAs with the following content all structured top to bottom as written down here

  • Quantity and Price field with already default input to current quantity and last-used settlement price image
  • Reason field Add a field with a input for reason - like the category, but labeled as Reason and with a Flexible text based input. Maximal 40 characters image
  • Fee section image
  • Summary Section Summary section that shows old holdings, followed below by new holdings and the difference between the two. Show if positive or negative
  • Adjust Button with "Adjust" as its content

Content for Internally Priced Assets

CTA click → slice out like for the other CTAs with the following content all structured top to bottom as written down here

  • Principal field with already default input to current principal image
  • Reason field Add a field with a input for reason - like the category, but labeled as Reason and with a Flexible text based input. Maximal 40 characters image
  • Fee section image
  • Summary Section Summary section that shows old holdings, followed below by new holdings and the difference between the two. Show if positive or negative
  • Adjust Button with "Adjust" as its content

Action

NOTE: Of course wrap in a batch and the respective remark.

  • IF updated holdings are GREATER than current holdings do a loans.increaseDebt(DIFF_BETWEEN_HOLDINGS) + fee transactions
  • IF updated holdings are SMALLER than current holdings do a loans.decreaseDebt(DIFF_BETWEEN_HOLDINGS) + fee transactions

mustermeiszer avatar Aug 26 '24 10:08 mustermeiszer

@mustermeiszer Should this CTA only be visible if an initial action on the asset (purchase/finance) has been done before? So similar to Sell, we shouldn't show Corrections until the Asset has been bought?

sonam-jo avatar Sep 16 '24 15:09 sonam-jo

Good idea and makes sense.

mustermeiszer avatar Sep 17 '24 08:09 mustermeiszer