apps icon indicating copy to clipboard operation
apps copied to clipboard
verified publisher icon centrifuge

Fix CFG price history on portfolio tab

Open hieronx opened this issue 1 year ago • 5 comments

Looks like the hosted uniswap v3 subgraph is removed. There is https://thegraph.com/explorer/subgraphs/5zvR82QoaXYFyDEKLZ9t6v9adgnptxYpKpSbxtgVENFV?view=Query&chain=arbitrum-one but that requires an API key. We need to figure out what is the best new data source.

hieronx avatar Aug 15 '24 15:08 hieronx

Image

Just wondering, is it meant to look like this?

0x4Graham avatar Sep 02 '24 07:09 0x4Graham

In this bug ticket only the CFG price graph that you can see if you click to send DEVEL or CFG was fixed.

Image

But I looked into why the graph you screenshotted is not showing. Turns out we manually disabled it about 3 months ago, I don't know why (maybe because it really doesn't look good in our app). After that we had a ticket to save space for all graphs on the page while they load to prevent jumping on the screen.

Image

So to summarize: Problem 1: graph was disabled, should we re-enable it? Problem 2: if the graph is disabled we should NOT save space for the graph (probs best for another bug ticket)

sophialittlejohn avatar Sep 06 '24 18:09 sophialittlejohn

@hieronx do you have context on why the graph was disabled? This page will be redesigned as well, so I am fine to keep it disabled and remove the space but defer to you

sonam-jo avatar Oct 15 '24 13:10 sonam-jo

I can't remember why it was disabled, seems to me we should re-enable it.

hieronx avatar Oct 15 '24 13:10 hieronx

What was fixed on this ticket? @sophialittlejohn I don't see any graph or any button that allows me to send?

0x4Graham avatar Feb 13 '25 16:02 0x4Graham

This is not something you would be able to test on demo unfortunately since we don't have subquery data. Turns out the graph is there but the subquery is down / no data it wont show.

kattylucy avatar Mar 04 '25 15:03 kattylucy