apps icon indicating copy to clipboard operation
apps copied to clipboard

Add asset P&L to Key metrics

Open hieronx opened this issue 1 year ago • 1 comments

For assets with valuation method == oracle, add Realized P&L and Unrealized P&L to the Key metrics card, above the YTM properties.

Realized P&L: Asset.sumRealizedProfitFifo from the subquery Unrealized P&L: Asset.unrealizedProfitAtMarketPrice from the subquery

hieronx avatar Jun 26 '24 20:06 hieronx

Is there a fund I can test this with @kattylucy @hieronx ? I can't seem to find one

0x4Graham avatar Jul 19 '24 11:07 0x4Graham

Not working for me @kattylucy.

There seems to be an issue with calculating the Unrealized P&L

Image

https://app-ff-production.k-f.dev/#/pools/4139607887/assets/8

0x4Graham avatar Jul 22 '24 09:07 0x4Graham

Good catch! Thankss @0x4Graham

kattylucy avatar Jul 23 '24 14:07 kattylucy

Fixed! Nice work @kattylucy

0x4Graham avatar Aug 02 '24 10:08 0x4Graham