apps icon indicating copy to clipboard operation
apps copied to clipboard

Exclude cash assets from asset counts

Open hieronx opened this issue 1 year ago • 5 comments

On both the Key metrics of the Pool overview and on the Assets tab, the Total assets & Ongoing assets counts should exclude cash assets.

hieronx avatar Jun 20 '24 09:06 hieronx

Hi @hieronx - do you mind adding a bit of context here? do we count cash assets in the total assets? I see this is not true for all the pools (right ?. How can I set up a test for this? TY

kattylucy avatar Jul 01 '24 13:07 kattylucy

Screenshot 2024-07-01 at 15 35 41

If you look at the Anemoy assets now. It is showing 10 total assets and 6 ongoing assets. This is including the Settlement Account, which is a cash asset. It should exclude this, so the total assets should be 9 and the ongoing assets should be 5.

hieronx avatar Jul 01 '24 13:07 hieronx

Is settlement account the only type of cash asset? @hieronx

kattylucy avatar Jul 01 '24 13:07 kattylucy

You should filter any asset where loan.pricing.valuationMethod === 'cash'

hieronx avatar Jul 01 '24 13:07 hieronx

Ah perfect. Thanks @hieronx

kattylucy avatar Jul 01 '24 13:07 kattylucy