cedvdb

Results 287 comments of cedvdb

@omar-hanafy I will have the time to try it in tomorrow, as a flyby review (I can help with those requests, sorry to be iterative but it would have been...

Maybe It should trigger on pop as well ?

The typecript definition of the likelyhood is : `google.cloud.vision.v1.Likelihood | "UNKNOWN" | "VERY_UNLIKELY" | "UNLIKELY" | "POSSIBLE" | "LIKELY" | "VERY_LIKELY" | null | undefined` Which makes it very confusing,...

@sofisl it can be either a number from the enum or a string from the union. ![image](https://github.com/user-attachments/assets/4456c6f1-ff85-4dd5-9816-d285a43b1589)

It was answered the comment before. Please reopen and change the label, or ask for further detail if that was not clear.

@codan84 what did you end up doing ? @sofisl did you have time to look into this ?

The existing test failure seems unrelated to the changes here and a publishable key is not set in your infrastructure: ``` IntegrationError: Please call Stripe() with your publishable key. You...

> but anything under lib is importable by anybody, which means you end up having to put your testing dependencies as regular dependencies, which can cause bloated downstream deps and...

@jakemac53 That makes sense. > opt in via configuration If I opt-in via configuration, I expect my dev_dependencies to work there. Currently even with ``` # dart_test.yaml paths: - lib/...

> wrapping path_utils does make it more readable. but not sure about changing the naming convention is worthing the breaking change. I believe it's possible to make it only internal...