cedvdb

The callback signature makes sense to me. The fallback router makes less sense to me. Since it's not the right instance, why would one use it ? Could you add...

> typically provided as this My bad, I misread the code and thought the fallback router was a parameter of the Router constructor, that we had to define ourselves, but...

Imo onEnter should be made asynchronous instead. One may query a local cache inside for example. I sent a PR on your fork that doesn't break the synchronous future usage

Both those tests should be added: - a test where router.go is used inside onEnter (which returns false since it handled navigation) - a test where router.push is used inside...

@omar-hanafy The current implementation of on enter is breaking `push` I changed the example found in `example/stateful_shell_route.dart` to add a floating action button that pushes a sign in page when...

> because I was mixing an imperative push (which is asynchronous and adds a new route on top) with a return value of false (which signals that the original navigation...

> Why is this not following the design doc for guards? I feel like we are deprecating redirect to get something similar We are definitely not getting something similar here...

> We need a mechanism to allow us to show something on screen during async gaps, while also enabling to continue, stop, deviate and resume the navigation. There is nothing...

> I don't think that returning classes is the way to go, this will limit the redirects to finish when we return. AutoRouter has a handler with methods, we call...

> it's better than what we have now, but once this lands, we won't be changing it any time soon, so I rather have it covering as many cases as...