Cecile Tonglet
Cecile Tonglet
Maybe a nice idea: developing our own code migration CLI?
@futursolo yes I just noticed there is an Rc in there nowadays! I started with `Self::Properties` in signature but I changed it to `&Self::Properties` because it's also easier to implement....
Ah I see! Thanks for the example I'm personally not super fan of this... It exposes the fact that we use Rc for storing props. Before making the PR I...
In my proposal in #2851 I'm using immutable reference. Does that sound good? ```rust fn changed(&mut self, ctx: &Context, old_props: &Self::Properties) -> bool { ```
Wouldn't it be better to just drop the type Key and use IString instead? It feels like unnecessary maintenance burden.
> Or AttrValue, which is more flexible... It's the same object, just a type alias ``` pub type AttrValue = implicit_clone::unsync::IString; ```
I'm not sure I understand why the #2616 was closed... did OP just gave up? That's sad.... Well okay so if I understand correctly we have 3 paths: 1. Accepting...
Thanks @WorldSEnder !! .... :thinking: looks like type erasure or something..... tbh I'm not sure to understand the sorcery but I'm open for a better option than what I'm doing...
> I actually think it would strain some users. nahh. In Rust you always have to call `.to_string()` to convert stuff to strings. It's just normal stuff. In the html!{}...
I think this PR is ready so please let me know if there is anything I need to fix.