Cecile Tonglet comments

Results 135 comments of


                                            Cecile Tonglet

Swap `From<Cow<'static, str>>` with `From<Cow<'_, str>>` for `IString`

> > I'm not sure about it but I think Cow static is the most common case and the other one only an exception. > > No clue, never used...

Swap `From<Cow<'static, str>>` with `From<Cow<'_, str>>` for `IString`

> Or make `From>`, that's why I think it's more useful. Maybe we can implement the Into for it and keep the From on Cow '_ str at the same...

Swap `From<Cow<'static, str>>` with `From<Cow<'_, str>>` for `IString`

I just tested to be sure but it seems it compiles: ```rust impl From) -> Self { match cow { Cow::Borrowed(s) => s.into(), Cow::Owned(s) => s.into(), } } } impl...

Swap `From<Cow<'static, str>>` with `From<Cow<'_, str>>` for `IString`

> This would be about having a conversion path into `Cow`. However, this PR is not about this. Because you swap the From Cow 'static with From Cow '_ we...

Swap `From<Cow<'static, str>>` with `From<Cow<'_, str>>` for `IString`

> since it is other way around no no sorry you got that wrong https://doc.rust-lang.org/std/convert/trait.From.html from automatically makes the into! Since you're swapping the from, we're losing both the from...