Carsten Brandt

Results 473 comments of Carsten Brandt

what exactly should this option do?

This sounds like making it all more complicated, creating a builder class for creating a config for configuring an object? This adds a new different syntax for the same thing...

what is the use case for this? Usually a pagination is applied to control the limit and offset. What is the meaning of the manually specified limit?

page size is controlled by the pagination, why set it manually?

To me it is unclear what this issue is about. - is it about performance? To reduce query count to one you can set `totalCount` on the dataprovider, but I...

what exactly do you expect? setting a limit and adding a pagination is ambigous. When you are on page 2 with limit 35 and a page size of 10. How...

So you want to paginate only part of the data? e.g. the query would return 100 records and you set limit to 50. with page size 10 you get 5...

agree this could be changed to make it more consistent. As it breaks BC, set for 2.1.

the workaround is already provided in the issue report. Add the div to the summary text.

You can already add plain string lines like this to add an index: ```php $this->createTable('tableName', [     'id' => $this->primaryKey(),     'name' => $this->string(),     'topic_id' => $this->integer(), 'KEY topic_id(topic_id)', 'FOREIGN KEY ......