ceastlund
ceastlund
Moving the semicolon to the next line still doesn't clarify whether it binds more or less tightly than "else", except via indentation. One way or another, a delimiter is needed...
I'm sympathetic to many of the above issues. Indeed, I wish some of the parenthesis handling were more uniform around infix operators. That might be worth a separate request. I...
I have added a separate feature request about symmetric use of delimiters: https://github.com/ocaml-ppx/ocamlformat/issues/1222
Is ppxlib_traverse meant for use outside of ppxlib? I believe it is currently used to generate ast traversal classes. I know in the new ppx we are doing this a...
Never mind that comment, @dwang20151005 showed me some other places ppxlib_traverse is used.
I don't know that this choice is entirely arbitrary. I think this rewrite still happens if the parentheses are preceded by: ``` do_something (); ``` That means the comment could...
Okay, if this is too tricky for now it's not a blocker. Thanks for taking a look.
This has tripped us up in a couple of ppxes at janestreet. Writing `esequence` using `fold_right` instead of `fold_left` appears to fix it.
I think `@@deriving_inline` only "needs no special treatment" when `ppxlib` is not run at all. Once you start preprocessing, `ppxlib` is going to want to know how to expand that...