Carsten Duvenhorst

icon location Germany icon location Economist, White-Hat, having a faible for understanding things, deep system researcher, fixing unwanted behaviour ;-) brief history: C64, Amiga, PPC, X86, Mac

Results 3 issues of Carsten Duvenhorst

Purpose key for precise location request as a parameter?

Currently the purpose key is hard coded as "OneTimeLocation". I suggest making this a configurable parameter for clarity and transparency reasons. https://github.com/malcommac/SwiftLocation/blob/f8ec8e97095eb3a5312370ad94b921768217625f/Sources/SwiftLocation/CLLocationManager/CLDeviceLocationManager/DeviceLocationManager.swift#L115

LINKER_SCRIPTS

1 comment

I think I have cracked your problem with the LINKER_SCRIPTS for OTA-Updater creation. Have a look at the Makefile of my sonoff-th-repo at https://github.com/cduvenhorst/sonoff-th-homekit .

Cast from UInt64 to Int could be problematic on macOS

3 comment

https://github.com/valhalla/valhalla/blob/5b3cd9704ffd699b992b08bc4a5bf60e34d318f5/src/tyr/serializers.cc#L442 num_lanes_blocked is defined as UInt64, writer writes Int. This gives an compiler error on default build configuration.

cleanup
good first issue