cdk-pipelines-github
cdk-pipelines-github copied to clipboard
cdklabs
#182 helps unblock users who are doing live lookup with their oidc role during the synth job. It still requires an additional `preBuildStep` from the user to allow this feature....
If I understand the approach, when you run `cdk synth` a Github workflow is produced and when executed the cdk.out assets are used to perform the CFN create/update stacks. What...
As I review aws-actions/configure-aws-credentials@v1 I see that it supports [session tagging.][1] And when I review the ['private' implementation][2] I get the sense that session tagging was not enabled on purpose....
The current GithubWorkflow design assumes that the CFN Execution Role that was [defined in the CDK Bootstrap][1] will be assumed during the Deployment. However, this is quite problematic for organizations...
Fixes #376 Continuing the description there: I've added `GitHubStage` which extends `Stage`, adding the properties of `AddGitHubStageOptions` to `StageProps`. `Stage` ignores them, and they quickly get lost in the conversion...
AFAIK it is not possible to pass typed context values using `--context`. See also https://github.com/aws/aws-cdk/issues/2204. This makes it impossible to get past the check at https://github.com/cdklabs/cdk-pipelines-github/blob/main/src/pipeline.ts#L300-L301: ```ts const diffProtection =...
[YamlFile.writeFile()](https://github.com/cdklabs/cdk-pipelines-github/blob/main/src/yaml-file.ts#L137) calls [YamlFile.toYaml()](https://github.com/cdklabs/cdk-pipelines-github/blob/main/src/yaml-file.ts#L121) which calls [JsonPatch.apply()](https://github.com/cdklabs/cdk-pipelines-github/blob/main/src/json-patch.ts#L29). There, patching is done with [applyPatch() from fast-json-patch](https://github.com/Starcounter-Jack/JSON-Patch#function-applypatchtdocument-t-patch-operation-validateoperation-boolean--validatort-mutatedocument-boolean--true-banprototypemodifications-boolean--true-patchresultt), which modifies the passed object. In CI, we first call [YamlFile.toYaml()](https://github.com/cdklabs/cdk-pipelines-github/blob/main/src/pipeline.ts#L303) in the diffProtection block, followed...
When running my workflow I'm currently receiving the following error: Prior to this step I changed to the workflows directory shown in the error and ran 'ls' to verify that...
This continues from the discussion in #365 with the `if` control. Looking at the docs for [`jobs..if`](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif), it appears that: 1. The `if` statement, if present, can allow a step...