Christian Dietrich

Results 152 comments of Christian Dietrich

we are now on gradle 6.

i think lsp4j should provide a facilitly to make this a oneliner in every implementer of ILanguageServer or even should provide default method. since the wait loop is done in...

maybe @akosyakov can give some hints how he implemented that in real world scenarios.

these other pures are generated by org.eclipse.lsp4j.generator.JsonRpcDataProcessor.generateImplMembers(MutableClassDeclaration, JsonRpcDataTransformationContext) delegating to org.eclipse.xtend.lib.annotations.AccessorsProcessor.Util

The simplest is to copy&paste the original code. You may also check if calling removeAnnotation on MutableField and MethodDeclaration works (similar to the calls on class here https://github.com/eclipse/xtext-xtend/blob/7c6989c0d362cdd3c0754d577989e849c3d1130e/org.eclipse.xtend.ide.tests/src/org/eclipse/xtend/ide/tests/macros/AbstractReusableActiveAnnotationTests.xtend#L674)

@pisv @szarnekow @jonahgraham i have updated this pr by - also remove the annotation for the adapters `TypeAdapterImpl` annotation - add copies of `ToStringBuilder` so we are compatible and dont...

should we also remove NoAnnotationTest or keep it?

@jonahgraham what do you think? ready to merge or wait another week? didnt follow if you built the patch from master or a dedicate maintenance branch

this pr is merged now. so using the nightly it should be possible to consume without guava, xtext and xtend cc @rgrunber @mickaelistria