Christian Dietrich
Christian Dietrich
have no idea how to test this if new manifest are ok / comparable to old ones. maybe we should check in manifests instead of generating them. i am also...
anyone have an idea why the PR builds are not working whist the branch build is? something broken how patches are applied to main and tested?
@jonahgraham no as you can see Jenkins PR Build is red but continuous-integration/jenkins/branch is green https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/cd_bmpXtendGradlePlugin/14/ https://ci.eclipse.org/lsp4j/job/lsp4j-github-pullrequests/253/
I would like to do it in two steps but first we need to do this one and I have no clue how to verify it
The problem is that the ci executes the old build with the new changes (In Jenkinsfile) So my new jenkinsfile is not picked
how shall we continue here
I am still not sure if everything is still working as intended. Have no clue eg how to test if jars and poms are comparable
will give a look if some of the diffs can be addressed by configuring the plugins differently
i can see Import-Package org.eclipse.lsp4j.jsonrpc.messages;version= "[0.16,1)" in the new variant too.
ok, can you formally approve, then we can merge and i can test with snapshot consuming in Xtext