Christian Dietrich comments

Results 152 comments of


                                            Christian Dietrich

Ensure diagnostics are published after cancellation

created https://github.com/eclipse-langium/langium/issues/1567 for further discussion

Ensure diagnostics are published after cancellation

@msujew i still think the problem is also that unlink/shouldRelink only evaluates document.references, but not the references that were attempted to link with the `get ref` call before, which does...

Ensure diagnostics are published after cancellation

i have tried my unlink changes on top of your invalidateDocument change. but i still see broken links after parsing step. need to check

Ensure diagnostics are published after cancellation

problem is the js you published. it has if (langiumDoc) { // const linker = this.serviceRegistry.getServices(uri).references.Linker; // linker.unlink(langiumDoc);

Ensure diagnostics are published after cancellation

will check.

Ensure diagnostics are published after cancellation

your invalidate with my unlink look promising.

Ensure diagnostics are published after cancellation

tests look good. will continue the analyze the deleted case. maybe the didChangeContent and the didChangeWatchedFiles reace with each other.

Ensure diagnostics are published after cancellation

delete case seems to be a client side problem. so here we are looking good

Ensure diagnostics are published after cancellation

a patch release would be welcome 🙏

Missing Proposals inside Datatype/Parser rules with "List"/repeat pattern

possible workaround ``` Thing: "thing" names+=ID ThingyRestList*; fragment ThingyRestList: ("." names+=ID); ``` ``` ID returns string: RawId | EscapedId; QualifiedName returns string: ID QNF*; fragment QNF returns string: ('.' ID);...