Chris Deline

Results 34 comments of Chris Deline

@shirubana - I think this quick bug fix is ready to go. Tests are passing aside for the minor delta in coveralls coverage.

Moved over to PR #488

OK, nevermind, we'll work on this branch to make it easier. Closing #488

Tests are passing, just a coveralls error. This is ready to merge with development. We can update journals from there.

This is not currently on our development pathway. conceptually there's a problem, namely this might require a full 3D vf treatment, because you'll have the north end of your tilted...

Yes, this is functional and has pytests. We might want to consider demonstrating the functionality in a notebook or two, with the new function name `readWeatherData`

Yes, thank you for the troubleshooting. I agree that the issue in the original script was with the line `results = analysis.analysis(octfile, demo.basename, frontscan, backscan)`. In this case it should...

So, inside makeScene1axis, we start with a `hub_height`, but that is changed to `clearance_height` for each timestamp when it is passed to `_makeSceneNxR`. I could pretty easily add back the...

Re: 'clearance_height' and 'hub_height': in `makeScene1axis`, when you pass in 'hub_height', it is converted to a 'clearance_height' and then passed in to `_makeSceneNxR`. In order to keep warning messages from...