bifacial_radiance icon indicating copy to clipboard operation
bifacial_radiance copied to clipboard

Published 20 hours ago • verified publisher icon NREL

Refactor NSRDBWeatherData

Open cdeline opened this issue 1 year ago • 1 comments

On the dev branch, refactor NSRDBWeatherData function to be a more general readWeatherData. This splits the existing readWeatherFile function into two parts - the first half for reading different weather files (TMY3, SAM, EPW, solarGIS) and putting it into a consistent format metadata dictionary and metdata DataFrame. Then the new readWeatherData function takes those inputs and does the parsing work. Now, NSRDB data can just be injected into the readWeatherData function without requiring any special function.

cdeline avatar Nov 30 '23 13:11 cdeline

did this got finished to merge ?

shirubana avatar Mar 12 '24 15:03 shirubana

Yes, this is functional and has pytests. We might want to consider demonstrating the functionality in a notebook or two, with the new function name readWeatherData

cdeline avatar May 20 '24 19:05 cdeline