Christian Decker
Christian Decker
We have been playing with a number of possible python installation options: - Using the system python install. This quickly leads to version conflicts for multiple python projects and often...
There is a second stacktrace by @Sjors here: https://github.com/ElementsProject/lightning/issues/7126#issuecomment-1976411464
It literally says that this failure is expected because we are sending a conflicting commitment tx to the peers close.
The change in the behavior appears to cause the `cln-grpc-plugin` to terminate almost immediately which is causing the tests to also fail right away. Can you check what is causing...
Please don't override the fixtures and the node class unless you absolutely need to. `options` passed to `NodeFactory.gey_node()` is where you can disable one and enable the other. Furthermore, the...
It's done automatically by instrumenting the pyln-client library to load and check the schemas. Anything going through pyln-client in a test environment should be checked afaik. I don't think notifications...
Agreed, initially we omitted the activation section on purpose as it allows for batch activation with other soft forks. The added template does not add clarifying information, rather it restricts...
Looking good but requires reading on top of `master`
ACK https://github.com/ElementsProject/lightning/pull/8740/commits/b0a4743697d19b158ef3092b12cf33ab7b857122
Thanks @jfrader, notice that we have switched away from `poetry` in favor of `uv` which presents a much simpler venv-management experience. We can remove the `poetry` references everywhere.