Christian Decker
Christian Decker
This appears to be a duplicate of #7402
From what I can tell this might be a timing issue with clboss being maybe a bit slow to shut down? The way we track plugin shutdowns may have an...
Ok, I'd like to have some more eyes on the script syntax, so I removed the milestone for now. Thanks for the excellent work @ddustin, and I'm sure we'll get...
Since the feerates changed, the thresholds for a couple of tests changed as well. Removing from milestone as we adjust the magic values in the tests.
Great work @daywalker90 that must've been quite a hunt. How did you drill down to find the differences? Diffiscope?
So you are using a salted-hash to ensure your own changes were not undone by someone else? Would a signature in that extra output be more idiomatic?
Shall we merge this, or would you like to dig deeper and see what is going wrong with Mac? In the latter case I'd remove the milestone.
@niftynei how are things looking? I plan to call a feature freeze on the weekend of the 29th, and I am planning on what to include and what to defer....
Very nice, thanks @s373nZ, I'll review the PR as soon as possible :+1:
Sure, the plugin just exposes the `/metrics` URL on a given port (concurrent tests are causing the flakiness), and then you configure your prometheus server to scrape that endpoint, which...