Marc Mueller

Results 381 comments of Marc Mueller

This PR would is ready now. Even without 3.14 in CI yet, this could be helpful to move #10467 forward. Tested the functional tests locally with 3.14.0rc1. The remaining issues...

Although this checker might be useful, I'm not sure we should add it to the main project. My suggestion would be an independently developed/managed addon. As a side node, I...

Fix for the license check: #144631

Not sure how practical or even possible it would be. In contrast to TypeScript, Python doesn't have an explicit `export` keyword. As such any module level variable could theoretically be...

> > how often would do you annotate function variables with `Final`? At least from my experience, this isn't something I normally do. > > To be honest I rarely...

> Regarding the name, [...] How do you like `consider-rewriting-conditional`?

> Very hard to tell what message warn about what here (without looking into the example). I was trying to bring a little more specificity into the new name. True....

> Did you consider [#10600 (comment)](https://github.com/pylint-dev/pylint/pull/10600#issuecomment-3363048003) (raising only above a threshold of or-linked negations ? This would make the check a lot more reasonable imo) > > > Regarding simplifiable-double-negation...

> If PyPI space is a concern, we still have most of a year before the default is flipped Yes, though I think we should look into it rather sooner...

@hauntsaninja Just saw that you're listed on PyPI as well. Are you able to view the remaining project storage for mypy?