Marc Mueller

Results 381 comments of Marc Mueller

> But not sure if we should add a new visit method in pylint or add a `get_children` method for match case in astroid so we ends up not having...

Cross posting https://github.com/pylint-dev/pylint/pull/10542#issuecomment-3263691148 here. IMO match in Python is basically an enhanced if statement. So checks should treat it similarly. AFAICT that was also your opinion on the ruff issue,...

> I'm thinking that they possibly want to make match case that are too complex without having to think about design too much (never saw a > 5 case match...

> Let's vote: Option : ❤️ No option: 🚀 I lean towards no option. If we add one, I think it should only be for `too-complex`.

Did a full run for Home Assistant. The new errors looked reasonable and were easy to fix. https://github.com/home-assistant/core/pull/120297

Just tested the preview style for pylint (with `25.12.0`). **`wrap_long_dict_values_in_parens`** Not entirely sure about this one, especially for strings. There are some good examples, e.g. ```diff { "type": "csv", "metavar":...

> Let's not rush this. Keeping a dedicated config is a conscious choice. Also, PRs must not reformat half a project along with changing the packaging configs. That's actually a...

> > That's actually a bug with the current black config. > > @cdce8p could you please extract a fix for this particular problem into a separate PR? A small...

Rebased the PR. Also moved the `dependencies` and `optional-dependencies` back to `setup.cfg` to purely focus on the static metadata. Please let me know if you're interested in moving this forward....

That's for the review @webknjaz! I'll address all comments in one to keep it readable. Please let me know if you have any followup questions. > Move dependencies to `pyproject.toml`...