Marc Mueller

Results 381 comments of Marc Mueller

A `NotEmpty` type could be quite helpful to reduce the number of false-positives for the new `possibly-undefined` check and the pyright `possibly unbound` check. /CC: @ilinum ```py def func(l: list[int])...

/CC: @erictraut I think this could also help `pyright`.

You could try making `LocalsDictNode` generic as well. The issues then just become recursive loops that crash even pyright / pylance 😄 Something like this. Note that I needed to...

Another suggestion would be to use a `Protocol` type instead of `LocalsDictNode` for typing. That could help prevent circular imports.

@raman325 Could you approve it? Since the integration has platinum level, the code owner approval is required before it can be merged.

> For Comelit was removed during review, but fine for me to add it again Tbh I don't really care either way. It does have some small benefits but that's...

@xeniter Please don't request me for a review every time. I just added one comment which I thought might be helpful at the time. Unfortunately I don't have the bandwidth...

Is it possible to make the mirror a bit more "official"? For example by moving the repo to the `psf` org? For bigger projects it's difficult to convince maintainers to...

> Just so I understand, is the advantage of the pre-commit mirror so it's a small faster mirror to check out rather than our larger checkout this repo would cause?...

> Ha, that makes it attractive given that Black on PyPI is mypyc-compiled whereas the one installed from source most certainly is not. Exactly, just as example for Home Assistant...