cdammanintopix

Results 16 comments of cdammanintopix

Allow to specify allowed groups to share instead of excluded groups

This is how it looks with the new UI: ![image](https://user-images.githubusercontent.com/63319198/190684063-f4c7d8f9-9150-4f0c-9453-2060d844091e.png) Let me know if I should change it. Also, should I update the translation files?

Allow to specify allowed groups to share instead of excluded groups

Just added testing :slightly_smiling_face:

Allow to specify allowed groups to share instead of excluded groups

New UI: ![image](https://user-images.githubusercontent.com/63319198/191063319-a1def067-1d40-4eeb-b168-fe1b1ea661b7.png)

Allow to specify allowed groups to share instead of excluded groups

Hello, @CarlSchwan any updates on this?

Allow to specify allowed groups to share instead of excluded groups

@jancborchardt sure, could be clearer. @nimishavijay ok with that change?

Allow to specify allowed groups to share instead of excluded groups

I rebased on the latest master commit, and updated the UI as @jancborchardt suggested. The new UI looks like this: ![image](https://user-images.githubusercontent.com/63319198/216295662-b98e7592-d1c8-4688-b030-9990ef851bf6.png)

Allow to specify allowed groups to share instead of excluded groups

Hello, do you think you could review this? @CarlSchwan This small pull request was opened about 10 months ago 🙂

Allow to specify allowed groups to share instead of excluded groups

Hello @CarlSchwan @icewind1991 any chance you could review this for next beta?

Allow to specify allowed groups to share instead of excluded groups

I updated the code to match the lastest release. The new UI looks like this ![image](https://github.com/nextcloud/server/assets/63319198/5dc49a54-c8a1-4b5f-9690-78980a30eede)

Allow to specify allowed groups to share instead of excluded groups

So after your review @come-nc do you confirm you approve this pull request?