César Carruitero

Results 37 comments of César Carruitero

I think is not necessary set both apis. Are you planning to change current?

@Rob--W, I'm not totally sure how to get the `sourceDir` `extensionId` reference without calculating the `extensionId`. If I'm missing something please let me know. After the extension is loaded we...

@Rob--W the PR is ready for a new review. The fail in travis is for an `addons-linter`'s dependency. https://github.com/mozilla/addons-linter/pull/3075 should fix the dependency problem in `addons-linter`.

@Rob--W I just noticed that isn't possible specify more than one source dir with web-ext commands, so I think we will have only one extension to reload. I updated the...

> Side note: out of curiosity, what sparkled your interest in this issue? I thought that you wanted the ability to reload individual extensions through the library, but from your...

@Rob--W I updated the logic for set the reloadableExtensions map. Take a look when you have a chance.

I would like to work on this. I was looking into the code, but not sure how to get the `sourceDir extensionId` reference. We load the extension passing `sourceDir` into...

@itzsaga we are using `tape` for tests. You can see the [test](https://github.com/workshopper/workshopper-adventure/blob/master/test/util.test.js) for an example, also take a look into [tape repository](https://github.com/substack/tape) @martinheidegger I was trying to add a test,...

Aside other minor comment, just prefer to squash commits before merge. I don't speak italian, so still need someone review translations.