Clemens Brunner

Results 317 comments of Clemens Brunner

I guess for EEGLAB export it is sustainable because it's not as complex as e.g. BrainVision or EDF export (since the format is basically a .MAT file). It would be...

I'm fine with extending existing functions, and the `mne.simulation` module seems like a good place for that functionality. Initially I thought because there is `mne.create_info()`, an `mne.create_toy_data()` would be the...

> I'd rather not add any new function. What you propose seems 90%+ like an existing function. No need to make something new to do almost the same thing just...

I'm not sure if it is a good idea to coerce `simulate_raw()` into not simulating and instead outputting some random data (with desired shape). I still think a separate function...

Scikit-learn has [`datasets.make_*()`](https://scikit-learn.org/stable/modules/classes.html#samples-generator) for this purpose BTW.

I thought you meant extending `mne.simulation.simulate_raw()`. I like adapting `mne.io.RawArray` to give an empty array, but how would you handle this with `mne.EpochsArray`? Pass a 2D array with `(n_epochs, n_channels)`?...

👍 for (2). There is a new `Self` type in `typing`, but let's better not go down this route.

> I have to say I never understood why we are explicitly prepending "instance of". It's inconsistent with how we specify input types, where we usually don't have these two...

What about: ``` Returns ------- inst : self The modified object if ``copy=False``. If ``copy=True``, this will be a copy with . ``` I'd also drop the name of the...

Can you post the output of `mne.sys_info()` please? It seems like you are using an old version, because `tqdm` has been removed from `mne.externals`.