Jim Brandt

Results 17 comments of Jim Brandt

I found three places that have a special case where the buttons were right next to each other and the update adds extra divs between, creating some extra space: share/html/Admin/Tools/GnuPG.html...

> I'd argue that the extra padding around those stacked buttons is an improvement, as it makes it a little bit less likely to accidentally mis-click and improves tapablity on...

The newest update makes sense, I just need some time to look again. Should be able to next week

I believe attr_match_list already supports trying multiple attributes for login. It currently attempts the search one at a time. Looking at the commit, it seems the main change is to...

Hi ciscoqid, thanks for the PR. Could you add some more detail to explain how the current format causes issues with mimecast (with an example) and how your change fixes...

> If there were more options available for $FriendlyFromLineFormat to select fields and subfields, I would definitely consider it. Yep, agreed, that's why I am suggesting that a PR that...

Thanks for the new example, @ciscoqid. As noted earlier, ideally we'd like to see a change that preserves backward compatibility and allows a flexible configuration to make it easy to...

Looks ok to me and makes sense. I would also add args for the col-3, col-9 classes. Default to col-3/9, but allow override. I think we have some cases with...

> I explicitly don't want to have calling code pass in hardcoded width values because those would force more brittleness into the layout engine that I'm pretty sure can be...

> @cbrandtbuffalo @sunnavy - when you can, let me know what changes you'd like to this PR. I think the right thing to do is to be targeting whatever the...