Chris Bracken
Chris Bracken
Migrates `FlutterViewController` from manual reference counting to ARC. Eliminates use of scoped_nsobject and scoped_nsprotocol, and migrates ivars to property syntax where possible. No semantic changes, therefore no changes to tests....
On most platforms, we support only a single host architecture and a single target architecture per build. macOS supports both arm64 and x86_64 host platforms via multi-arch (universal) binaries generated...
When run repeatedly, some of the iOS unit tests can relatively easily blow their test timeouts. Since we're testing behaviour and not performance in these tests there's no need to...
Followup to migrating all iOS translation units to compilation with ARC. https://github.com/flutter/engine/blob/205484009711c2f0d85a4c45666d187184493b41/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm#L299-L321 and https://github.com/flutter/engine/blob/d38f5e560a98f491fb1b3e24e19cc78d2b110b99/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm#L979-L988
During ARC migration in https://github.com/flutter/flutter/issues/137801 we left behind some unfortunate `__bridge` casts. In the interest of safety and readability, we should eliminate these where possible.
Calling helper methods in initialisers and dealloc is unsafe. Methods should only ever be called on fully initialised objects since methods can be overridden in subclasses. The iOS FlutterViewController calls...
The certificate renewal process is described in [How to renew the DeviceLab development certificate](https://g3doc.corp.google.com/company/teams/flutter/infrastructure/devicelab/apple_cert_renewal.md) (Google-internal). In the _Create the new signing certificate_ section, we rely on a DeviceLab bot to...
On an arm64 Apple Silicon Mac, the published `gen_snapshot` binaries are `x86_64` and therefore run with Rosetta translation. ``` android-arm-profile/darwin-x64/gen_snapshot android-arm-release/darwin-x64/gen_snapshot android-arm64-profile/darwin-x64/gen_snapshot android-arm64-release/darwin-x64/gen_snapshot android-x64-profile/darwin-x64/gen_snapshot android-x64-release/darwin-x64/gen_snapshot ``` Compile Android `gen_snapshot` binaries...
While testing locally, I noticed that `[IOSSurfaceNoopTest testCreateSurface]` was (correctly) failing because nullptr was being passed through an `FML_DCHECK` check. Fix in https://github.com/flutter/engine/pull/55621 However, the question is how this test...