engine icon indicating copy to clipboard operation
engine copied to clipboard

iOS: Reduce rerun flakes by eliminating timeouts

Open cbracken opened this issue 1 year ago • 3 comments

When run repeatedly, some of the iOS unit tests can relatively easily blow their test timeouts. Since we're testing behaviour and not performance in these tests there's no need to enforce a particular timeout.

The bots will fail if the tests timeout, regardless.

Issue: https://github.com/flutter/flutter/issues/157231

Pre-launch Checklist

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [X] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [X] I listed at least one issue that this PR fixes in the description above.
  • [X] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [X] I signed the CLA.
  • [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cbracken avatar Oct 21 '24 20:10 cbracken

cc @hellohuanlin as we were chatting about this. No action needs to be taken right now.

sethladd avatar Aug 28 '24 01:08 sethladd

fyi @jmagman

sethladd avatar Aug 28 '24 02:08 sethladd