Colin B. Macdonald

Results 291 comments of Colin B. Macdonald

The box details don't matter too much. Here's an updated version that shows the file is actually written, and contains the text. Not sure if this is harmful or just...

I can reproduce the previous comment: ``` In [2]: fitz.version Out[2]: ('1.23.3', '1.23.2', '20230831000001') In [3]: d = fitz.open("1.-.Copy.pdf") In [4]: d.subset_fonts() --------------------------------------------------------------------------- ValueError Traceback (most recent call last) Cell...

I have a possibly-related issue where 1.24.3 leaves some misc chars on the page, which go away if I *stop* using subset_fonts. Haven't narrowed it down to a MWE yet,...

ping? this looks good to me too. Shall I tackle the docs bit in a new MR?

I only skimmed this but do you mean `min` rather than `max`?

@JorjMcKie Do you know what "parm angle" means here? does it mean "reduce angle parameter by"? ``` betar -= w90 # reduce parm angle by 90 deg alfa += w90...

Only two more errors where I'm uncertain what change to make (see above). After we make those, this is ready to go! If you like feel free to move the...

Did I break this test somehow? ``` Traceback (most recent call last): File "/home/runner/work/PyMuPDF/PyMuPDF/scripts/gh_release.py", line 714, in main() File "/home/runner/work/PyMuPDF/PyMuPDF/scripts/gh_release.py", line 115, in main build(valgrind=valgrind) File "/home/runner/work/PyMuPDF/PyMuPDF/scripts/gh_release.py", line 378, in...

Thanks @julian-smith-artifex-com I think I've done those changes but the test is still failing :( > I think there's a trivial indentation error in the patch that's causing the test...