Colin B. Macdonald

Results 291 comments of Colin B. Macdonald

I dunno about this... > These functions cannot be private because ... This bothers me. I guess I'd rather they were private without `__` on their names?

Just to keep our priorities in order: our upstream makes use of `eval` [1]. Not that we should ignore security stuff at our end, of course. [1] https://github.com/sympy/sympy/issues/10805

Does the built-in one work with symbolic input? I don't think the built-in one works with symbolic input: ``` >> cart2pol(sym(4),sym(5)) error: cart2pol: X, Y must be numeric arrays of...

@alexvong1995 here's a half-baked idea for Issue #1124: roughly when we have non-`Expr` to be put in a `Matrix`, we instead make an `Array`. This will be important for future...

@alexvong1995 What do you think of this? Basically in a few places (probably not that many) we return Array instead of Matrix. Specifically we return Matrix greedily whenever everything is...

that could be true: I haven't looked at pythonic much recently. You can always comment out "dbout()" (it is just debugging). With Pythonic you can probably just `print()` instead. Anyway,...

@alexvong1995 you can rebase and force push this on top of main (if you like).

I think there was a way to turn an warning into an exception in Python. That might be useful when debugging here... like `SymPyDeprecationWarning` becomes an exception.

And just checked and this now works, presumably b/c of the #1060 fix. So I guess we can use it in CI for example

Still seems to run tests for all packages not just symbolic :( Doesn't happen locally