cbergqvist

Reviewed 58cb22c. Great to finally add support for JSON-RPC 2.0, thanks for doing this! (Super-late concept reflection: it might be more modern to provide something like [OpenAPI](https://swagger.io/) instead of JSON-RPC...

ACK 58cb22c All reasonable arguments! Would be a scary to see new default values for parameters in consensus critical code - but this is not, and it's very unlikely it...

Couldn't reproduce the CI timeout issue btw. But I have encountered the warning: ``` 2024-02-22T22:01:47.354000Z TestFramework.p2p (WARNING): Connection lost to 0:0 due to [Errno 104] Connection reset by peer ```

Built 5f313495eea36b566109894697b4a90085c53113 and ran bitcoin-qt because I was worried that setting a very high max value might cause issues with the QT UI control. It's not some kind of horizontal...

> > If the user has specified both, presumably he wants both to be used... > > And they are, just not at the same time. > > The same...

> From where I see it that is literally prioritizing one over the other. Before the aforementioned change, both would race, after the change, `seednode` was given a 1 min...

> According to your logs, it doesn't even look like any connection is attempted after the addr-fetch and defaulting to DNS seed. Are you sure your fetched node has any...

ACK 2842e51a246b162a586941184b7694f187d7aee7 Diffed top 2 commits in that and 78482a09e06beb841e70781eb509c2b2fdea8bd9 which I previously tested & acked. Only scope of `start`-variable was narrowed as suggested by @davidgumberg in https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1526788396.

@grdddj please mirror commit ea86110 which I just added as well

CI failure would be fixed by. ```diff diff --git a/src/net.cpp b/src/net.cpp index 01522a6286..36889a6da6 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -3269,9 +3269,7 @@ bool CConnman::Start(CScheduler& scheduler, const Options& connOptions) // Randomize...