Chris Beer

Results 137 issues of Chris Beer

With Hashie 3.4.2, this code used to work ``` ruby require 'timeout' require 'confstruct' Confstruct::Configuration.new(timeout: 1) ``` Using 3.4.3, this fails with: ``` ArgumentError: The property timeout clashes with an...

I was surprised recently, when I tried to filter out a particular file from coverage analysis that this usage [1]: ``` SimpleCov.start do add_filter 'lib/some/file/to/ignore.rb' track_files '{app,lib}/**/*' ``` results in...

Bug
Docs

The `deprecation` gem was initially extracted from Rails before support for other gems landed (in Rails 5.x). This will require some minor tweaks to downstream applications that used `Deprecation.silence` etc,...

- [x] https://github.com/projectblacklight/blacklight/pull/2780 - [x] https://github.com/projectblacklight/blacklight/pull/2782 ![Screen Shot 2022-07-20 at 17 06 20](https://user-images.githubusercontent.com/111218/180102872-f37d1c71-e63d-4873-a60b-398de8728274.png) - [ ] pagination should not have rounded corners (upstream bug: https://github.com/twbs/bootstrap/issues/36820) ![Screen Shot 2022-07-20 at 17...

Feature

In 8.x, I think we'd be fine requiring the scope to define `search_state_class`, but I also think forward-porting this is fine too. The samvera community has a lot of non-controller...

Part of #2781 Accordions seem to have most of the relevant styling... we just need to fight the upstream code a little because we put spacing between the items 🤷‍♂️...