Mihai Cazacu

Results 21 comments of Mihai Cazacu

Hi, Is there any progress on this? Thank you!

We can include [these](https://github.com/jiecao-fm/hashids-java/pull/53#issuecomment-367466481) points in the `TODO` list. Also, the `2.0.0` branch can be started from [this](https://github.com/jiecao-fm/hashids-java/pull/53) point.

I have fixed the formatting. The performance consists in: - using operations directly to the char arrays instead of using `String`; - some operations (like computing the `validChars`, `guardsRegExp`, `sepsRegExp`,...

About the performance: I have gained about 100-200 ms for running all the tests (it is at least 20% more efficient).

About breaking this pull request in smaller pieces: I can't do this because the most part of it is related to the migration from `String` to `char[]`. I may extract...

Sure, I can do that.

I have changed the source code and another error appears, mentioning that the `this._map` is null. The fix consists in replacing [this](https://github.com/Leaflet/Leaflet.draw/blob/c6af99b761c5d9900bf5a3e2e1d8827bbde29542/src/edit/handler/Edit.SimpleShape.js#L63) line with: `if (shape._map && this._map)`.

@eisverticker: I've tested your fix and it works. I'll delete my PR. Thank you!

I also have this issue. Distributor ID: Neon Description: KDE neon User - 5.25 Release: 20.04 Windows Gaps 7.1