Mitch VanDuyn comments

Results 234 comments of


                                            Mitch VanDuyn

params should always attempt to run "to_xxx" on in coming objects if type doesn't match

problem is that method(:login) returns a object of class Method not class Proc as the param expects. You can do method(:login).to_proc to get rid of the warning. The real problem...

Implements ReactiveRecord::Collection#create

Adam this looks good. I was reading through the rails docs, and discovered another version of create (for the belongs_to relationships) I added an issue for it (https://github.com/hyperstack-org/hyperstack/issues/408) which looks...

memory leak in RenderingContext

Here is a patch that I've been testing... suggest we just use as is for now: ```ruby module React class RenderingContext class

memory leak in RenderingContext

Nope

memory leak in RenderingContext

Yes I think so

Stateless Components

I'm closing this... Its easy enough in ruby to just have an include file with your stateless methods.

Stateless Components

after thinking about this I realize that a stateless method is not the same thing as a stateless component. A stateless method will get re-rerendered even if its params do...

StateWrapper doesn't do set_state when using []=

yeah I just noticed this as well... i think perhaps the intent at one time was to give a low level direct access to the underlying react state hash, and...

new model should be initialized with default values from schema

but it would be a breaking change...

new model should be initialized with default values from schema

because its a breaking change it should probably work like this: add a switch to hyperstack that turns this ON, (but the default is off) however. However if the value...