Carter Nelson

Results 295 comments of Carter Nelson

@tahunus Those app notes look useful. Thanks. The `setThreshholds()` method only alters the touch/release threshold registers (`0x41`-`0x5A`). There are no dedicated methods for changing the AFE & FCR registers. **AFE...

Thanks! Adding forum post for ref: https://forums.adafruit.com/viewtopic.php?f=47&t=177750

Bummer it doesn't just work with the address, even though it goes against the datasheet: ![image](https://github.com/adafruit/Adafruit_SGP30/assets/8755041/2515db24-6629-4fc8-9fae-3188adf3f43c) Sounds like you've verified it must done per datasheet. Have you gone as far...

@gorghino Did you try @Chesteron suggestion? Your sketch is not calling `IAQinit()`. ![image](https://user-images.githubusercontent.com/8755041/193080404-3259a1cb-0d3f-426f-972a-408098cedcaa.png)

Basically, just need to run it. ``` clang-format -i Adafruit_MPL3115A2.cpp ``` It'll reformat to its liking and then commit/push those changes. More info: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

This needs #33, so looking at that one first.

> so duplicated code (the whole _read() method) can be removed. Don't the other derived classes still need `_read()` from the `LSM6DS` base class?

Oh, sry, was reading the code diff wrong. The `_read` was removed from the derived class `Adafruit_LSM6DSO32`. Not the base class. OK, this looks like some nice code clean up....

Sorry. Wanted to find a time to test this on hardware. Went ahead and set something up for testing. Looks like something isn't quite correct somewhere. Running the [adafruit_lsm6dso32_test.ino](https://github.com/adafruit/Adafruit_LSM6DS/blob/master/examples/adafruit_lsm6dso32_test/adafruit_lsm6dso32_test.ino) example...

Yah, looks like a typo. Luckily just cosmetic, since it's a constant and the code at least is consistent with the usage. Would you be willing to make a PR...