Zhefeng C.

icon location Shanghai, China

Results 21 comments of Zhefeng C.

fix(request-transformer) an empty JSON array after being decoded, can…

> done

The poolname doesn't include the client cert info for mtls authentication

> I don't have a problem with that. Perhaps it could be a "weak" dependency in some way though? Because most people won't need it, it might be nice to...

If we do tests in a loop, it seems we don't have an easy way to prompt which iteration failed

yeah, if all tests pass, everything is ok. If some tests fail, then I need to check them one by one to figure out which one fails.

If we do tests in a loop, it seems we don't have an easy way to prompt which iteration failed

OK, I can try.

Kong's log system does not allow you to set fields with dots

@ms2008 This should be a separate issue from https://github.com/Kong/kong/pull/11091 . That one is about validation failure when the key contains dots, while this one is because the dot character has...

feat(hmac-auth): add support for RSA signatures

Please add an entry in `removed_fields.lua`

feat(hmac-auth): add support for RSA signatures

Strictly speaking, rsa doesn't belong to hmac. The scope of the plugin name feels a little small now. Maybe something like "sign-auth" would have been better

fix(cmd): lack of necessary nginx directives in kong cli nginx.conf

detach the "drop luasocket in cli" part to a separate [PR](https://github.com/Kong/kong/pull/11177) so that this PR is easier to review. Also because these two PRs are relatively logically independent.

fix(cmd): lack of necessary nginx directives in kong cli nginx.conf

> Is this needed for 3.4 (it's in the milestone)? @kikito Yes, I think so. it was moved from 3.3 to 3.4 because of pursuing a more generic approach. >...

fix(cmd): `kong vault get` doesn't work in dbless mode

Agree. The current fix is a bit hacky. Better to have a more generic way.