Tim Chevalier

Results 36 comments of Tim Chevalier

cc @echeran -- I didn't fix the copyright scan errors since you mentioned you would help with legal signoff re: licensing for the nlohmann/json library. cc @srl295 @roubert -- I...

> good work and a couple of comments > > * i see two copies of ujson.h and probably only need one > Thanks for spotting that, fixed. > *...

> * should have some mention of checking that the license doesn't change I think your suggested change, which I incorporated, addresses this?

OK, I think I've incorporated all the licensing changes you suggested, @echeran and @srl295 -- can you look again? Thanks!

> Hm, I didn't realize before that there were configurations that used `-Werror` without also using `-Wall -Wextra`, maybe this'll be a bit easier to maintain if only those get...

> Now you got it backwards, `-Wctad-maybe-unsupported` should go together with `-Werror -Wall -Wextra`. Oops. Should be fixed now.

I spent some time looking into this. The bug, or at least surprising behavior, is that test262-harness parses the metadata out of all the files in the current working directory,...

In any case, the bug title should probably be something more general, like "syntax error in one test causes all tests in the same directory to fail."