icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22740 Add missing template arguments in MF2 parser

Open catamorphism opened this issue 1 year ago • 5 comments

This fixes a clang-17 -Wctad-maybe-unsupported warning.

Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22740
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [ ] Issue accepted (done by Technical Committee after discussion)
  • [x] Tests included, if applicable
  • [x] API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

catamorphism avatar Apr 18 '24 19:04 catamorphism

cc @roubert @echeran

catamorphism avatar Apr 18 '24 19:04 catamorphism

Hm, I didn't realize before that there were configurations that used -Werror without also using -Wall -Wextra, maybe this'll be a bit easier to maintain if only those get the new warning added.

Fixed in b849e63

catamorphism avatar Apr 22 '24 20:04 catamorphism

Fixed in b849e63

Now you got it backwards, -Wctad-maybe-unsupported should go together with -Werror -Wall -Wextra.

roubert avatar Apr 22 '24 20:04 roubert

Now you got it backwards, -Wctad-maybe-unsupported should go together with -Werror -Wall -Wextra.

Oops. Should be fixed now.

catamorphism avatar Apr 22 '24 21:04 catamorphism

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot