Casper Beyer
Casper Beyer
This was brought up in slack as-well, PR welcome.
Looks promising, will do some testing locally with some chaos sprinkled in.
> I tried something out with merging. Let me know if this approach will work. It looks at the call signature on every connect() call, so that's not ideal but...
There's one failing test, but this is failing on main as-well so I don't think that's related.
Ran the meta benchmarks on this as they're pretty request heavy: ``` JetStreamCreate/N=1,R=1,storage=Memory,C=12/resource=Stream-14 593.6µ ± ∞ ¹ 618.6µ ± ∞ ¹ ~ (p=1.000 n=1) ² JetStreamCreate/N=1,R=1,storage=Memory,C=12/resource=KVBucket-14 1.065m ± ∞ ¹...
Blocked-By: #612
Closing this as stale, server merged the changes.
Blocked-By: https://github.com/nats-io/nats-server/pull/5858
Aye we should be logging what events we see. Three options as as I see it. 1. Add a span for it. 2. Bump log level 3. Keep as is.
The long term end goal here (for all of rust) would probably be that rust moves ahead with keyword generics or a similar initiative. See: https://blog.rust-lang.org/inside-rust/2022/07/27/keyword-generics.html https://www.youtube.com/watch?v=MTnIexTt9Dk