Results 12 comments of Casper

@trallnag should this be merged?

What about the ordering of the objects with the old FK? Will there be a gap where the changed object was? If so, would calling `self.bottom()` in the save method...

Consider four objects: | FK | Object | Order | |----|--------|-------| | 1 | A | 0 | | 1 | B | 1 | | 1 | C |...

I had a problem using `OrderedTabularInline` in the admin with these changes. It would initialise all related objects, calling the new `__init__` function and setting `self._original_order_with_respect_to_fks` correctly. However, as a...

Thank you for updating the repo today @imomaliev -- especially the `bulk_create` is very handy. I am using the following changes locally to achieve the behavior of this pull request...

Yes, I am deploying a `GitRepository` (and tf-runner `RoleBinding`/`ServiceAccount`) as part of a helm chart. This issue occurs on helm uninstall. Relatedly, I am also having issues with helm uninstalling...

In my particular case, the problem with the `GitRepository` would probably be solved by a solution to our discussion https://github.com/weaveworks/tf-controller/discussions/238, as I would no longer need to deploy a `GitRepository`.

Actually, @chanwit, a good solution would maybe be to add some kind of finalizer to the `GitRepository` (and perhaps the `ServiceAccount`/`RoleBinding`)? I envision something not unlike `PersistentVolume`, from the [docs](https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/#how-finalizers-work):...

I'm honestly not too familiar with Kubernetes finalizers, but does a finalizer necessarily have to delete an object, as much as it is a blocker for deletion? My model is...

Looking forward to it!