Casey Rodarmor
Casey Rodarmor
I'm almost tempted to close this in favor of #1023, since I think they're basically the same thing, a per-recipe scope for expressions. But there's good discussion here so whatever.
That's an interesting option. I think it's a downside that you have to add a group to a recipe if you want scoped variables, and you have assignments which potentially...
> That being said, I think invalid attributes being accepted on assignments is an inadvertent bug which should be fixed, so this is potentially backwards compatible. Fixed in #2412.
A wacky option would be to allow defining inline modules, place the recipe you want to have its own scope in the module, and then use normal assignments within that...
I think I'm inclined to implement this with inline modules, since it's more general and powerful, although it might take awhile for someone to get around to it. See #2442...
#2442 is big, so it may take a while.
Nope, unfortunately not. I think we wouldn't want to add this, because of security considerations.
Okay, actually, that is extremely cool. I'm now tempted to add it 😅 I'm going to open this so we can think about it. It's very dangerous, but as a...
My personal opinion is that it's probably not worth waiting for those issues to be fixed before integrating rustfmt. I've had issues with every code formatter that I've ever used,...
LGTM!