Gerard Casas Saez

Results 70 comments of Gerard Casas Saez

What python version are you in? You may need to reduce the version of python to one that is supported by tfx 1.4

Okay, I think I found a fix. Change this in version.py ``` _CI_MIN_CONSTRAINTS = [ f"tfx~={_INCLUSIVE_MIN_TFX_VERSION}", "tensorflow~=2.6.0", "apache-beam[gcp]

you should fix it as part of the PR as otherwise CI wont let you merge it (as CI as of now its failing)

Sorry I should have specified more. I meant if you can add ` "firebase-admin

I believe I may also be able to commit to your branch if you prefer me to do that

this looks better now :D /lgtm will let you merge at your own discretion (just comment the merge command to merge that should merge the code)

Seems the CI job is failing due to pickling issues - https://github.com/tensorflow/tfx-addons/runs/5340812545?check_suite_focus=true

> I think it needs TFMA head / next release to work You can modify requirements.txt to point to TFMA HEAD so we can make sure its green before merging.

yup. we can update once tfx is released to make sure. Meanwhile may be good to fix the linter issues (I can do it otherwise)

you can manually run pre-commit based on https://github.com/tensorflow/tfx-addons/blob/main/CONTRIBUTING.md#python-coding-style