Update sklearn_predict_extractor.py

[1025KB]

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

• [ ] Tests pass
• [ ] Appropriate changes to README are included in PR

[github-actions[bot]]

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

[1025KB]

Some context, needs TFMA release to work

https://github.com/tensorflow/tfx/pull/4533

[TheMichaelHu]

There appears to be a conflict between python formatters being used.

/lgtm

[github-actions[bot]]

Approval received from @TheMichaelHu! :white_check_mark:

PR is approved. Missing merge command to auto-merge PR!

[casassg]

Seems the CI job is failing due to pickling issues - https://github.com/tensorflow/tfx-addons/runs/5340812545?check_suite_focus=true

[1025KB]

Seems the CI job is failing due to pickling issues - https://github.com/tensorflow/tfx-addons/runs/5340812545?check_suite_focus=true

I think it needs TFMA head / next release to work

[casassg]

I think it needs TFMA head / next release to work

You can modify requirements.txt to point to TFMA HEAD so we can make sure its green before merging.

[1025KB]

I think it needs TFMA head / next release to work

You can modify requirements.txt to point to TFMA HEAD so we can make sure its green before merging.

I updated to least tfma version but has conflict, needs to wait for next tfx release

[casassg]

yup. we can update once tfx is released to make sure. Meanwhile may be good to fix the linter issues (I can do it otherwise)

[1025KB]

yup. we can update once tfx is released to make sure. Meanwhile may be good to fix the linter issues (I can do it otherwise)

Curious, is there a quick cmd to fix lint? seems the git lint is different from my internal env :(

[casassg]

you can manually run pre-commit based on https://github.com/tensorflow/tfx-addons/blob/main/CONTRIBUTING.md#python-coding-style

[casassg]

Closing this as we archived the example