Marco Casaroli
Marco Casaroli
Try with the following job: ```yaml Env-Test: runs-on: self-hosted steps: - run: echo LOGS_DIR=/tmp >> $GITHUB_ENV - name: do something env: OUTDIR: ${{ env.LOGS_DIR }} run: | echo LOGS_DIR=$LOGS_DIR echo...
> would you mind sharing some screenshots of both the bug you're fixing with this and the result of the change? I updated the PR description, please check it. Thank...
@microsoft-github-policy-service agree
well, it fixed most builds. and the ones that are failing are due to a different error
Can anyone help me understand why the workflow is failing? What should I do to fix it?
> need fix the ci error first: https://github.com/apache/nuttx/actions/runs/11194947243/job/31122067924?pr=13527 done
I believe I have addressed all the concerns. Can you please provide another review? @xiaoxiang781216 @fdcavalcanti
> Now that's what I call a well written PR. Congrats again. Was able to reproduce the issue and make some recommendations. Well, you should thank @lupyuen's bot :sweat_smile: :sweat_smile:
> I see this PR is pulling in the complete RPI Pico SDK. > > But that kinda goes against the [The Inviolable Principles of NuttX](https://nuttx.apache.org/docs/latest/introduction/inviolables.html#the-inviolable-principles-of-nuttx) > > Please check...
thank you @PeterBee97 for taking over this. I will soon add the other pimoroni boards.