cartographer_ros icon indicating copy to clipboard operation
cartographer_ros copied to clipboard

[ROS-O] release tag split off master branch?

Open v4hn opened this issue 2 years ago • 0 comments

For some reason you decided to split off a branch to tag the release 1.0.0. Sadly, as a result git describe --tag in the master branch shows 0.3.0 . That becomes a problem when building in ROS-O because cartographer_ros also explicitly depends on cartographer_ros_msgs >= 1.0.0 in the master branch, but as we use the last git tag in the history to decide the version number of the packages, the version there is 0.3.0, failing the check. To circumvent the issue, I switched to the release-1.0 branch for now, but I would like to have at least one build farm running on the latest heads, so I'm unhappy that your branch fails with this series of unfortunate events (in addition to claiming it's still version 0.3.0). You are the only of several hundred packages that hits this problem and I was wondering whether/how you could address it on your side.

Is there any chance you will do a 1.0.1 release from the current master branch without splitting off before release? Could you drop the offending version_gte attribute? Do you consider it valid use to split of a branch before a release and then assume that the master branch has the same version without that showing up in the history of the branch?

v4hn avatar Feb 05 '23 23:02 v4hn