Carter Kozak

Results 73 issues of Carter Kozak

## What happened? We do a great deal of unnecessary string concatenation in span names which can be completely avoided for unsampled traces: https://github.com/palantir/tracing-java/blob/c63567eacecc677c63db0f146fcd2f34493f2ffa/tracing-jersey/src/main/java/com/palantir/tracing/jersey/TraceEnrichingFilter.java#L62 https://github.com/palantir/tracing-java/blob/c63567eacecc677c63db0f146fcd2f34493f2ffa/tracing-okhttp3/src/main/java/com/palantir/tracing/okhttp3/OkhttpTraceInterceptor.java#L42 ## What did you want...

enhancement

## What happened? TraceEnrichingFilter fails to close spans when AsyncResponse is used.

bug

The default sampler should not cause a local service to observe operations, but it should also not prevent upstream tracing-aware services from recording trace data based on their local sampler...

enhancement

## What happened? Log lines inside a traced operation contain a `traceId` [MDC](https://www.slf4j.org/api/org/slf4j/MDC.html) key. Tracing output may be loaded by ID in our logging pipeline, however most traceIds are not...

enhancement

Proposal: Opening a span returns a token used to safely close that span, it should not be possible to close the wrong span using this API.

enhancement

By returning the completed span we require execution to be traced regardless of whether it will be observed. We can avoid this additional work when tracing is not requested. The...

enhancement

It should not be possible to create a new trace without also creating a root span. The current API allows for an undefined gap between creating a trace, and opening...

enhancement

==COMMIT_MSG== Update to latest jdk17 base image ==COMMIT_MSG==

merge when ready
no changelog

==COMMIT_MSG== Test latest httpclient release ==COMMIT_MSG==

do not merge

It seems that the heuristics have gone a bit sideways in JDK-21 causing degenerate full gc pauses unnecessarily when we configure `-XX:MaxGCPauseMillis=500`, however setting the default 200ms value resolves this...

do not merge
merge when ready
autorelease