tracing-java icon indicating copy to clipboard operation
tracing-java copied to clipboard

span completion should not return the completed span

Open carterkozak opened this issue 7 years ago • 1 comments

By returning the completed span we require execution to be traced regardless of whether it will be observed. We can avoid this additional work when tracing is not requested. The solution to #34 should cover this case.

Potential non-break (API bend?): completeSpan returns an optional of the completed span, we may be able to return an empty optional when the trace is not observed.

carterkozak avatar Nov 01 '18 20:11 carterkozak

Isn't this the reason why we have fastCompleteSpan too?

j-baker avatar Nov 16 '18 20:11 j-baker